Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35226 )
Change subject: src/soc/intel/common/block/cse: Add helper functions to CSE lib
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block...
PS14, Line 76: me_hfs
which status register is this ? STS1 ? if yes then we already have the definitions in soc directory. […]
Yes, this is as same as STS1. But, the STS1 structure used different field names. If we have to generalize this part, we can move all me related stuff to common. Most of the ME functions are dumping and decoding STSx registers, and have been implemented same differently across socs.Can we do this change as part of separate task?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5c12b7abdb27c38af74ea6ee568b42ec74bcb3c
Gerrit-Change-Number: 35226
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Sep 2019 05:09:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment