Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44538 )
Change subject: soc/amd/picasso: Reboot for recovery if no psp workbuf is found ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44538/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44538/1//COMMIT_MSG@14 PS1, Line 14: needed for that process you should elaborate as to why
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/Kconfig... PS1, Line 510: 0x6F How was this offset chosen?
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/psp_transfer.h:
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/include... PS1, Line 12: 0x96 What is the significance of this value? And why is the macro name have a _FLAG in it? This is a value of a byte we're setting.
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/psp_ver... PS1, Line 234: if (retval) goto err? Seems like it should be a post_code(retval) based on what I see. But a vboot error isn't set for retval.