Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43893 )
Change subject: mb/intel/tglrvp: Add support for USB Type-C connector device properties
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43893/3/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/ec.c:
https://review.coreboot.org/c/coreboot/+/43893/3/src/mainboard/intel/tglrvp/...
PS3, Line 11: static void ramstage_ec_init(void)
: {
: const struct google_chromeec_event_info info = {
: .log_events = MAINBOARD_EC_LOG_EVENTS,
: .sci_events = MAINBOARD_EC_SCI_EVENTS,
: .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,
: .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,
: .s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS,
: };
:
: printk(BIOS_DEBUG, "mainboard: EC init\n");
:
: google_chromeec_events_init(&info, acpi_is_wakeup_s3());
: }
This should be all that you need to include in `mainboard_ec_init()`, the ec_lpc module will initialize the LPC decoding (as done below)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43893
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd4c59afb3b8a222598fd4ff36d72c4b877bdad2
Gerrit-Change-Number: 43893
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 27 Jul 2020 18:43:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment