Attention is currently required from: Elyes Haouas, Nico Huber.
Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83909?usp=email )
Change subject: include/stdbool: Fix useless type name in empty declaration error ......................................................................
Patch Set 6: Code-Review+2
(3 comments)
Patchset:
PS6: The change looks good, but I think the commit message could be updated with info on why this is an issue.
Commit Message:
https://review.coreboot.org/c/coreboot/+/83909/comment/3bf8e216_e1d1c843?usp... : PS6, Line 7: include/stdbool: Fix useless type name in empty declaration error I preferred your original subject:
include/stdbool: Don't unconditionally typedef bool
I think we just need to explain why as in my below comment.
https://review.coreboot.org/c/coreboot/+/83909/comment/3b5aa2e2_86486a15?usp... : PS6, Line 8: Maybe add something like "When compiling with the C23 standard, bool, true, and false are pre-defined by the language, so defining them in stdbool.h isn't allowed."