Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Julius Werner, Gwendal Grignou.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50210 )
Change subject: drivers/i2c: sx9310: Replace register map with descriptive names
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50210/comment/41306c88_d2c20e40
PS3, Line 7: drivers/i2c: sx9310: Use open source variables
yes, the original driver in the kernel was using chip registers map to configure the SAR sensor, whi […]
Done
Patchset:
PS6:
Gwendal, you're not dealing with coreboot all that often: our Gerrit instance is configured so that comments need to be marked "Resolved" before a change can go in.
File src/drivers/i2c/sx9310/sx9310.c:
https://review.coreboot.org/c/coreboot/+/50210/comment/7c438c81_58d2885d
PS3, Line 70: * proximity/semtech,sx9310.yaml
Yes: https://www.kernel.org/doc/Documentation/devicetree/bindings/iio/proximity/s.... […]
Done
File src/drivers/i2c/sx9310/sx9310.c:
https://review.coreboot.org/c/coreboot/+/50210/comment/203deec0_52fcd7c2
PS6, Line 69: * Format describe in linux kernel documentation. See
the formatting seems off here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d1c81b56eaeef1dbb0f73c1d74c3a20e8b2fd7b
Gerrit-Change-Number: 50210
Gerrit-PatchSet: 6
Gerrit-Owner: Gwendal Grignou
gwendal@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Gwendal Grignou
gwendal@chromium.org
Gerrit-Comment-Date: Fri, 05 Mar 2021 11:01:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Gwendal Grignou
gwendal@chromium.org
Gerrit-MessageType: comment