[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/geralt: Init MT6359P only once in ramstage

[Liju-Clr Chen (Code Review)]

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72839 )

Change subject: mb/google/geralt: Init MT6359P only once in ramstage
......................................................................

Patch Set 2:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/72839/comment/fc436278_c34a4212 
PS1, Line 7: Calling
> (Please use imperative mood: Call instead of Calling) […]

Done

https://review.coreboot.org/c/coreboot/+/72839/comment/86a4b487_8fbe78e3 
PS1, Line 10: add
> move mt6359p_init() to mainboard. […]

Done

https://review.coreboot.org/c/coreboot/+/72839/comment/6d37db5e_a31b94bd 
PS1, Line 10: mt6359
> mt6359p?

Done

https://review.coreboot.org/c/coreboot/+/72839/comment/e96c6474_aa32b9ac 
PS1, Line 12:
> What user visible problem does multiple initialization cause?

mt6359p_init() will call pmic_efuse_setting(), so pmic_efuse_setting() are called twice. 11 msecs will be increased on booting time.

File src/soc/mediatek/mt8188/msdc.c:

https://review.coreboot.org/c/coreboot/+/72839/comment/d9dc2190_77234cac 
PS1, Line 13: #include <soc/mt6359p.h>
> remove

Done