Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48499 )
Change subject: arch/x86: Move .id section higher
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48499/2/src/arch/x86/bootblock.ld
File src/arch/x86/bootblock.ld:
https://review.coreboot.org/c/coreboot/+/48499/2/src/arch/x86/bootblock.ld@2...
PS2, Line 22: _ID_SECTION_END = SIZEOF(.fit_pointer) && SIZEOF(.id) > 0x28 ? 0xffffff80 : _X86_RESET_VECTOR;
: _ID_SECTION = _ID_SECTION_END - SIZEOF(.id);
Would it make sense to document this primary/secondary ID section offset here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d3a58c82efd3bbf94f4bc80ec5bbc97d5b1c109
Gerrit-Change-Number: 48499
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Dec 2020 18:35:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment