Attention is currently required from: Matt DeVillier, Tim Wawrzynczak, Paul Menzel, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58271 )
Change subject: arch/x86/smbios: Add generation of type 20 table
......................................................................
Patch Set 6:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/58271/comment/5ec3032a_9748cf81
PS4, Line 1073: +=
there's one type20 table per dimm; start_addr starts at 0 and increments by the size of the dimm for […]
Note that end_addr is start_addr plus the size of the DIMM, so start_addr is doubled each time. I guess you haven't noticed anything wrong because your machines have at most 2 DIMMs, and 0 * 2 = 0 (start_addr begins at 0).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58271
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2574d6209d973a8e7f112eb3ef61f5d26986e47b
Gerrit-Change-Number: 58271
Gerrit-PatchSet: 6
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 12 Oct 2021 16:11:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment