Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34835 )
Change subject: drivers/ipmi: make IPMI KCS status and command register offset configurable ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig File src/drivers/ipmi/Kconfig:
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@5 PS2, Line 5: choice
Yes it is board/BMC specific, but coreboot needs to modify the offset to match BMC's configuration, […]
please remove the choice
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@26 PS2, Line 26: config KCS_REGISTER_OFFSET The spec uses the name "spacing" instead of offset. I'd prefer IPMI_KCS_REGISTER_SPACING.
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@28 PS2, Line 28: default 1 if KCS_REGISTER_OFFSET_1 default 1
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@31 PS2, Line 31: depends on IPMI_KCS in monolake mainboard Kconfig do:
config IPMI_KCS_REGISTER_SPACING default 4