Attention is currently required from: Subrata Banik, Matt DeVillier, Julius Werner, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63209 )
Change subject: device/i2c_bus: Add detect function pointer in i2c_bus_ops
......................................................................
Patch Set 3:
(1 comment)
File src/include/device/i2c_bus.h:
https://review.coreboot.org/c/coreboot/+/63209/comment/254d6e22_5064199c
PS3, Line 14: bool (*detect)(struct device *dev, unsigned int addr);
I think what Julius might have been getting at is should we just use the i2c_simple interface instead? e.g.
```
static inline int i2c_write_detect(unsigned int bus, uint8_t addr)
{
struct i2c_msg seg;
seg.flags = 0;
seg.slave = addr;
seg.buf = NULL;
seg.len = 0;
return i2c_transfer(bus, &seg, 1);
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8ddfb187eabec966c253b6cc8526491c99151fc
Gerrit-Change-Number: 63209
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 22:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment