V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31787 )
Change subject: soc/intel/cannonlake: Move power_state functions to pmutil.c
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31787/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31787/2//COMMIT_MSG@10
PS2, Line 10: It allows the functions to be used across romstage and smm.
:
Can this not be achieved by just adding power_state. […]
Yes, that will also work but since power_state.c was residing inside romstage specific folder and if i had to include power_state.c to smm stage, then i had to include it inside the romstage Makefile. Instead i thought of moving it outside the romstage folder so that i need not include smm stage inside romstage specific folder.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If24c3feeb77f4fb692ef0bf38d537b2b54de3c36
Gerrit-Change-Number: 31787
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Mar 2019 18:35:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment