Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Martin Roth, Nikolai Vyssotski.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81887?usp=email )
Change subject: soc/amd/glinda : Add support for A0 and B0 steppings
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81887/comment/8d892482_1df764ae :
PS2, Line 7: soc/amd/glinda :
Please remove the space before the colon.
https://review.coreboot.org/c/coreboot/+/81887/comment/c1f2c634_0d3e0883 :
PS2, Line 9: Update the A0 and B0 stepping IDs in CPU table
Please mention the datasheet name and revision.
File src/soc/amd/glinda/include/soc/cpu.h:
https://review.coreboot.org/c/coreboot/+/81887/comment/5cbb9822_92eb0876 :
PS2, Line 6:
Use tabs?
https://review.coreboot.org/c/coreboot/+/81887/comment/10eedbfa_5aef0685 :
PS2, Line 6: 0x1A
Lowercase?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81887?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0072f25f981ac7d5df2522594c8788bfabcbf24c
Gerrit-Change-Number: 81887
Gerrit-PatchSet: 2
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 17 Apr 2024 08:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment