Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31811 )
Change subject: [NOTFORMERGE] PCI accessor testcases
......................................................................
Patch Set 2:
So my theory here is, the casting to (volatile void *addr) when calling write32() is the culprit; this with alias with any other pointer variables, essentially invalidating dev, dev->bus (and optionally non-constant var_mmconf_base here) from registers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31811
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ca4d5556d2ac80986a909cf4df029ee575f3940
Gerrit-Change-Number: 31811
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Mar 2019 05:08:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment