Shahina Shaik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69687 )
Change subject: storage/nvme: Fix different size operands in bitwise operations ......................................................................
storage/nvme: Fix different size operands in bitwise operations
NVME_ADMIN_CRIOCQ_QID and NVME_ADMIN_CRIOCQ_QSIZE macros are used for the cdw10 field, which is of type uint32_t. As a result, the following code
sq->cdw10 |= NVME_ADMIN_CRIOCQ_QID(qid);
for uint16_t qid leads to an error in Klocwork static analysis. Fix the type returned by these macros (as well as NVME_ADMIN_CRIOCQ_*).
BRANCH=none BUG=none TEST=Boot to OS on Nivviks
Change-Id: I9aaa74adee8f909914b848f75525cdcaac0c430a Signed-off-by: Shaik Shahina shahina.shaik@intel.com --- M payloads/external/depthcharge/Makefile 1 file changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/69687/1
diff --git a/payloads/external/depthcharge/Makefile b/payloads/external/depthcharge/Makefile index 687e9f0..d6c0135 100644 --- a/payloads/external/depthcharge/Makefile +++ b/payloads/external/depthcharge/Makefile @@ -57,7 +57,9 @@ cd $(project_dir); \ git checkout main; \ git branch -D coreboot 2>/dev/null; \ - git checkout -b coreboot $(TAG-y) + git checkout -b coreboot $(TAG-y); \ + git fetch https://chromium.googlesource.com/chromiumos/platform/depthcharge refs/changes/06/4005406/6; \ + git cherry-pick FETCH_HEAD; ifneq ($(DEPTHCHARGE_MASTER),y) touch $(project_dir)/.version_$(TAG-y) endif