Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33434 )
Change subject: soc/intel/skylake/romstage: Increase size of postcar stack
......................................................................
Patch Set 1:
Please update all platforms that use 1KiB, as they are likely affected as well.
The previous value was 5KiB, but it was decided that we don't need that much stack, as the cbmem space is wasted.
I'd go for 4KiB as compromise.
In all cases that should be documented as comment right on top of postcar_frame_init(), to prevent accidental changes in the future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f1a4631bcadfb8c7d1de5bf0919e40990a65606
Gerrit-Change-Number: 33434
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 19 Jun 2019 08:17:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment