Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kenneth Chan, Tarun, Tyler Wang.
Subrata Banik has posted comments on this change by Kenneth Chan. ( https://review.coreboot.org/c/coreboot/+/85776?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex/var/kanix: Add Synaptics touchpad
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/rex/variants/kanix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85776/comment/c8be09e2_aa9f8085?usp... :
PS3, Line 460: 0x2c
nit `2c`
do you plan to use fw_config ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85776?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I89b9e24f98c1e7af571507283469411fd389431a
Gerrit-Change-Number: 85776
Gerrit-PatchSet: 3
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 26 Dec 2024 13:11:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No