Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38454 )
Change subject: mainboard/puff: Fix ACPI tables to advertise correct features ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38454/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38454/5//COMMIT_MSG@7 PS5, Line 7: mainboard/puff: Fix ACPI tables to advertise correct features I believe the variant prefix for Chrome devices is different.
Also, maybe:
Advertise correct features in ACPI tables
is shorter, and it’s clear, it’s a fix.
https://review.coreboot.org/c/coreboot/+/38454/5//COMMIT_MSG@15 PS5, Line 15: don't exist. Text width is 75 characters.
https://review.coreboot.org/c/coreboot/+/38454/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/38454/5/src/mainboard/google/hatch/... PS5, Line 4: * Copyright (C) 2018 Intel Corporation. Why? You are employed by Google?
https://review.coreboot.org/c/coreboot/+/38454/5/src/mainboard/google/hatch/... PS5, Line 51: * ACPI related definitions for ASL code. Dot/period could be removed.