Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44653 )
Change subject: drivers/spi/tpm: Add helper to get cr50 firmware version ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44653/1/src/drivers/spi/tpm/tpm.h File src/drivers/spi/tpm/tpm.h:
https://review.coreboot.org/c/coreboot/+/44653/1/src/drivers/spi/tpm/tpm.h@4... PS1, Line 47: Indicates whether Cr50 observes AP reset using SYS_RESET# signal.
If we want to keep this function as a common helper routine, then we should add a comment explaining […]
Add a more generic function to return the cr50 firmware version.
https://review.coreboot.org/c/coreboot/+/44653/1/src/drivers/spi/tpm/tpm.h@4... PS1, Line 48: cr50_sees_ap_reset_on_sys_reset
On a second thought, passing firmware version seems more generic than the cr50_firmware_pltrst_on_wr […]
Done
https://review.coreboot.org/c/coreboot/+/44653/1/src/drivers/spi/tpm/tpm.c File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/44653/1/src/drivers/spi/tpm/tpm.c@8... PS1, Line 856: cr50_firmware_version.epoch == 0 && cr50_firmware_version.major == 0 && : cr50_firmware_version.minor <= 22
Can you please check with Mary or Namyoon to get a confirmation on what firmware version really supp […]
Added a more generic function to return Cr50 firmware version.
https://review.coreboot.org/c/coreboot/+/44653/1/src/drivers/spi/tpm/tpm.c@8... PS1, Line 860: printk(BIOS_INFO, "Cr50 firmware does not use SYS_RESET#, version: %d.%d.%d\n", : cr50_firmware_version.epoch, cr50_firmware_version.major, : cr50_firmware_version.minor);
Is this print really required? It is not really accurate. […]
Ack