Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/41343 )
Change subject: haswell: Make VGA on FDI work
......................................................................
Patch Set 9:
Patch Set 9:
(9 comments)
Nice coding!
Just the CLKOUT_DP disable path seems odd.
It's missing!
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/41343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: Ieabe3b7f947be2ef488ddb57bfeae85fa055d360
Gerrit-Change-Number: 41343
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Jul 2020 13:49:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment