Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38003 )
Change subject: mainboard/google/puff: Enable net driver on pcie ep
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38003/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/38003/3/src/mainboard/google/hatch/...
PS3, Line 25: if BOARD_GOOGLE_PUFF
Why did you remove this check? Not all hatch variants have NIC.
Because the linker will remove the driver symbols if it has not been instantiated in the devicetree of the variant. There is no need for kconfig combinatoric games. Please see the discussion on https://review.coreboot.org/c/coreboot/+/37909 for the background.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38003
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76ce6d8a5a26842fcb2544ee96567fe0da8603b1
Gerrit-Change-Number: 38003
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-Comment-Date: Tue, 31 Dec 2019 08:40:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-MessageType: comment