build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47496 )
Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................
Patch Set 5:
(11 comments)
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 75: PAD_CFG_GPO(GPP_R5, 1, PLTRST), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 75: PAD_CFG_GPO(GPP_R5, 1, PLTRST), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 76: /* CAM2_RST */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 77: PAD_CFG_GPO(GPP_E15, 1, PLTRST), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 77: PAD_CFG_GPO(GPP_E15, 1, PLTRST), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 78: /* CAM1_PWR_EN */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 79: PAD_CFG_GPO(GPP_B23, 1, PLTRST), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 79: PAD_CFG_GPO(GPP_B23, 1, PLTRST), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 80: /* CAM2_PWR_EN */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 81: PAD_CFG_GPO(GPP_E16, 1, PLTRST), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 81: PAD_CFG_GPO(GPP_E16, 1, PLTRST), please, no spaces at the start of a line