Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik.
Julius Werner has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/83680?usp=email )
Change subject: soc/intel/adl: Update DCACHE_BSP_STACK_SIZE for Brox
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I tried 64 KiB for Coreboot, but CAR is too full with that. Hence settled down to 32 KiB.
32 should be fine.
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83680/comment/dde610c4_23462375?usp... :
PS2, Line 194: if BOARD_GOOGLE_BROX_COMMON
I think we should just update the value, not make it different for every board. The only reason not to increase it would be to maintain compatibility with older RO firmware but we already have branches for that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83680?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I723ba1f4289c393fe7376f989d760b26e75b33da
Gerrit-Change-Number: 83680
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 29 Jul 2024 22:48:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com