Attention is currently required from: shkim, Henry Sun, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian. SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 )
Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ......................................................................
Patch Set 5:
(8 comments)
File src/mainboard/google/dedede/variants/bugzzy/ramstage.c:
https://review.coreboot.org/c/coreboot/+/60190/comment/d0e08791_1ce716fc PS4, Line 17: * Bugzzy uses panel-built-in touch screen, it needs : * to set panel power and reset signal to high for touch : * screen to work. : * On user mode, coreboot doesn't initialize graphics : * since there is no screen display before OS. We would : * add this WA to initialize required signals on user mode.
Please reflow for 80 (or 96) characters per line.
Done
https://review.coreboot.org/c/coreboot/+/60190/comment/46124eb7_05dcb180 PS4, Line 33: addr32 = 0xc0010000; // IGD MMIO BASE
Add define or enum?
Done
https://review.coreboot.org/c/coreboot/+/60190/comment/6498b5a9_18ea6a52 PS4, Line 37: // clear bit3 ~ bit0
Not needed.
Done
https://review.coreboot.org/c/coreboot/+/60190/comment/26328809_5e140452 PS4, Line 47: udelay(20 * 1000);
mdelay(20)
Done
https://review.coreboot.org/c/coreboot/+/60190/comment/74ba7155_c4be160f PS4, Line 47: udelay(20 * 1000); // delay 20ms
Please mention the datasheet name, revision and section requiring this. […]
simon@intel, Can you advise for this? and can you confirm the proper value is 20ms or 200ms?
https://review.coreboot.org/c/coreboot/+/60190/comment/a9918e36_af29bcb0 PS4, Line 49: //reset high
Space after //.
Done
https://review.coreboot.org/c/coreboot/+/60190/comment/223b3416_5029c262 PS4, Line 59: //reset low
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/60190/comment/3a45bf9b_32d250db PS4, Line 69: //reset high
Ditto.
Done