Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42022 )
Change subject: mb/facebook/watson: support firmware version ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42022/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42022/2//COMMIT_MSG@7 PS2, Line 7: mb/facebook/watson: support firmware version
It’d be nice to have *SMBIOS* in there: […]
Done
https://review.coreboot.org/c/coreboot/+/42022/2/src/mainboard/facebook/wats... File src/mainboard/facebook/watson/ramstage.c:
https://review.coreboot.org/c/coreboot/+/42022/2/src/mainboard/facebook/wats... PS2, Line 16: */
Use SPDX header?
This patch is for 4.11 branch. I intend to align with the style of rest of the files.
https://review.coreboot.org/c/coreboot/+/42022/2/src/mainboard/facebook/wats... PS2, Line 29: * firmware version.
Re-flow for 80 or 96 characters to fit in two lines?
Done