Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Angel Pons.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68448 )
Change subject: mainboard/msi/ms7d25: Add support for DDR5 variant
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68448/comment/eb5aa734_3b779638
PS3, Line 7: mainboard
Could be abbreviated as *mb*.
https://review.coreboot.org/c/coreboot/+/68448/comment/1c4c8cd4_d09a02fd
PS3, Line 12: TEST=Boot MSI PRO Z690-A board successfully to Ubuntu 22.04.
It’d be great if you added, what DIMMs you tested with.
File src/mainboard/msi/ms7d25/Kconfig:
https://review.coreboot.org/c/coreboot/+/68448/comment/980d9a28_95049b32
PS3, Line 4: config BOARD_MSI_Z690_A_PRO_WIFI
If this is the DDR5 variant, why not append `_DDR5`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I652a879d1616df4708fe4690797ad98384897f53
Gerrit-Change-Number: 68448
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 07:46:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment