Attention is currently required from: Arthur Heymans, Chen, Gang C, David Hendricks, Jincheng Li, Jonathan Zhang, Lean Sheng Tan, Nicholas Chin, Patrick Rudolph, Paul Menzel, Shuo Liu, TangYiwei, Varshit Pandya.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81319?usp=email )
Change subject: mb/intel/avenuecity_crb: Add GNR/SRF-AP 2S server board Avenue City ......................................................................
Patch Set 39: Code-Review+1
(3 comments)
File src/mainboard/intel/avenuecity_crb/config/iio.c:
https://review.coreboot.org/c/coreboot/+/81319/comment/061b8a03_9ff7f97b : PS36, Line 14: _IIO_PORT_CFG_STRUCT_X8(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x1), : _IIO_PORT_CFG_STRUCT_DISABLED, : _IIO_PORT_CFG_STRUCT_DISABLED, : _IIO_PORT_CFG_STRUCT_DISABLED, : _IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x2), : _IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x3), : _IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x4), : _IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x5)
Yes, they matters. The minimal port elements are x2. […]
Right-to-left sounds is a bit confusing
File src/mainboard/intel/avenuecity_crb/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/81319/comment/28272b8a_a59a1171 : PS39, Line 11: // OEM revision I *think* this comment is inaccurate. Would be good to remove it.
File src/mainboard/intel/avenuecity_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/81319/comment/9702b219_3bd3fcfe : PS39, Line 33: return false; I'd add a TODO comment