Attention is currently required from: Hsuan-ting Chen, Jakub Czapiga.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80621?usp=email )
Change subject: tests/lib/ux_locales-test: Simplify macros ......................................................................
Patch Set 2:
(2 comments)
File tests/lib/ux_locales-test.c:
https://review.coreboot.org/c/coreboot/+/80621/comment/81eb7bf2_8233ee7b : PS2, Line 190: _expect
Just want to confirm: so for found, we will display like `expect="translation_1_0"` (with quotation) […]
Exactly.
https://review.coreboot.org/c/coreboot/+/80621/comment/cc0b6040_5e8a870b : PS2, Line 210: NULL
Maybe `NULL /* No text found */` would be more clear.
I think the comment for `UX_LOCALES_GET_TEXT_TEST` is already pretty clear that `NULL` means "text not expected to be found".
Or, do you prefer keeping the `UX_LOCALES_GET_TEXT_FOUND_TEST` and `UX_LOCALES_GET_TEXT_NOT_FOUND_TEST` macros? In that case, the macros can still be simplified.