Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68485 )
Change subject: soc/mediatek: Add support for input 1P mode of dp_intf
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/common/dp/include/soc/dp_intf.h:
https://review.coreboot.org/c/coreboot/+/68485/comment/ac8a4077_255c22b4
PS3, Line 263: extern struct mtk_dpintf dpintf_data;
Can this be `const` (also for the first argument of `mtk_dpintf_` functions)?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68485
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d138b0ff75e005518bc8fcce06df20924b2a6ba
Gerrit-Change-Number: 68485
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 03:37:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment