Attention is currently required from: Furquan Shaikh, Kyösti Mälkki, Aaron Durbin, Patrick Rudolph. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51631 )
Change subject: [WIP] soc/intel/braswell: Use SOC_INTEL_COMMON_BLOCK_I2C ......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/braswell/acpi/lpss.asl:
https://review.coreboot.org/c/coreboot/+/51631/comment/71ff3e43_1cda1286 PS1, Line 104: /* Standard Mode: HCNT, LCNT, SDA Hold Time */ : Name (SSCN, Package () { 0x200, 0x200, BOARD_I2C1_DATA_HOLD_TIME }) : : /* Fast Mode: HCNT, LCNT, SDA Hold Time */ : Name (FMCN, Package () { 0x55, 0x99, BOARD_I2C1_DATA_HOLD_TIME }) I have no clue weather there is a dependency to this inside the OS. I understand your motivation for this change but I guess someone with access to said boards should have a look and provide matching values instead of deleting them completely.
File src/soc/intel/braswell/chip.c:
https://review.coreboot.org/c/coreboot/+/51631/comment/b0c499d4_8e15deb3 PS1, Line 144: i2c_frequency(config, 0); The API does not match here (additional second parameter ), I guess hence the Jenkins-error?