Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58386 )
Change subject: cpu/x86/lapic: Unconditionally use CPUID leaf 0xb if available
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
cpuid_ext(0xb, 0).edx is 0 on all cores on picasso. […]
so this patch is likely correct, but the hardware doesn't behave as expected at all. i was told that the nipperkin variant of guybrush which uses a cezanne soc behaves as expected, so this might only affect picasso. still investigating
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f1f46fe5091ebeab6dfb4c7e151150cf495d0cb
Gerrit-Change-Number: 58386
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 09 Feb 2022 21:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment