build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39425/13/src/soc/intel/xeon_sp/incl...
File src/soc/intel/xeon_sp/include/soc/lewisburg_pch_gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/39425/13/src/soc/intel/xeon_sp/incl...
PS13, Line 339: #define NUM_GPIO_COMx_GPI_REGS(n) (DIV_ROUND_UP((n), GPIO_MAX_NUM_PER_GROUP)
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idde32fdd53f1966e3ba6b7f5598ae8f51488d5a5
Gerrit-Change-Number: 39425
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Mar 2020 19:24:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment