Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31445 )
Change subject: soc/intel/cannonlake: Add a power control workaround for SD controller
......................................................................
Patch Set 8:
Patch Set 8:
(2 comments)
Please note that neither does hatch set `SdCardPowerEnableActiveHigh` nor is the UPD ever set (the chip.h field is simply ignored). Which means that at the end of this patch train, both redundant options are already out of sync.
it was set to 1 as a default, i think that was reason it was not added. Will update the params.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31445
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee262d7ecdf8c31362aec3d95dd9b3e8359e0c25
Gerrit-Change-Number: 31445
Gerrit-PatchSet: 8
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Feb 2019 10:09:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment