Attention is currently required from: Tim Wawrzynczak, Robert Chen, Nick Vaccaro, Shon Wang.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting
......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS7:
I will review in more details tomorrow.
But here is my quick feedback.
I'm recommending to split this CL into atleast 3 CLs as below:
- Add I2C driver for CS35L53 support.
Please consider to check CB:52395 commit msg and while splitting this CL.
- Configure GPIO for vell variant.
- Let Brya Kconfig.name to select this for vell variant and required override dt changes.
File src/drivers/i2c/cs35l53/cs35l53.c:
https://review.coreboot.org/c/coreboot/+/60331/comment/6a44514c_afba9391
PS7, Line 2:
one interesting observation that I have post reviewing this Cirrus Logic 35L53 and Cirrus Logic CS42 […]
@Tim/Nick, what do you think ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
Gerrit-Change-Number: 60331
Gerrit-PatchSet: 7
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 Jan 2022 07:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment