Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80554?usp=email )
Change subject: soc/intel/common/block/sata: Fix scope for SATA ACPI device ......................................................................
soc/intel/common/block/sata: Fix scope for SATA ACPI device
acpi_device_path() includes the device name, so we end up with: Scope (_SB.PCI0.SATA) { Device (SATA) { ...
Fix this by using acpi_device_scope() instead.
TEST=build/boot purism librem_cml (Mini v2), dump ACPI and verify SATA device scope correct.
Change-Id: Ibbc8890d93b22f0ecba4b3a9b0531994574b3d55 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/80554 Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Sean Rhodes sean@starlabs.systems Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de --- M src/soc/intel/common/block/sata/sata.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Sean Rhodes: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Felix Singer: Looks good to me, approved
diff --git a/src/soc/intel/common/block/sata/sata.c b/src/soc/intel/common/block/sata/sata.c index 96c33ef..96b7390 100644 --- a/src/soc/intel/common/block/sata/sata.c +++ b/src/soc/intel/common/block/sata/sata.c @@ -9,7 +9,7 @@
static void sata_acpi_fill_ssdt(const struct device *dev) { - const char *scope = acpi_device_path(dev); + const char *scope = acpi_device_scope(dev);
if (!scope) return;