Attention is currently required from: Bora Guvendik, Hannah Williams, Jay Patel, Boris Mittelberg.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72930 )
Change subject: ec/google/ec_cmd: EC command for pre-reset boot timestamps
......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72930/comment/5c2e579e_a4efda96
PS7, Line 2: jaypatel256
Please configure your local git:
$ git config --global user.name "…"
$ git commit --amend --authohr="… <…>"
https://review.coreboot.org/c/coreboot/+/72930/comment/881df289_4ab8fcc2
PS7, Line 7: ec/google/ec_cmd: EC command for pre-reset boot timestamps
Please make it a statement by adding a verb (in imperative mood): Add EC command …
https://review.coreboot.org/c/coreboot/+/72930/comment/5f02e9f4_0e8c2750
PS7, Line 11:
Please add a reasoning/motivation.
https://review.coreboot.org/c/coreboot/+/72930/comment/a0ddfa55_f39e44b3
PS7, Line 15: jaypatel256
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9324c844c04472b5ed07c5e11e263037712df59
Gerrit-Change-Number: 72930
Gerrit-PatchSet: 7
Gerrit-Owner: Jay Patel
jay2.patel@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Jay Patel
jay2.patel@intel.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 07:46:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment