Attention is currently required from: Robert Zieba, Raul Rangel, Paul Menzel, Reka Norman, Nick Vaccaro.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62905 )
Change subject: util/spd_tools: Add support for exclusive IDs
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
This change is not impacting the default behavior of the SPD generation tool or SPD ID generation to […]
oh, i compared K4U6E3S4AB-MGCL with K4UBE3D4AB-MGCL and not each with the similar but not quite the same dram chips. so unless there's something else to put in the spd that is different for the dram chips, this seems to be the way to go even though i don't like the idea too much
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife5afe32337f69bc06451ce16238c7a83bc983c8
Gerrit-Change-Number: 62905
Gerrit-PatchSet: 8
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Mon, 21 Mar 2022 20:10:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment