Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34706 )
Change subject: arch/x86: Change smm_subregion() prototype
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34706/7/src/soc/intel/cannonlake/in...
File src/soc/intel/cannonlake/include/soc/smm.h:
https://review.coreboot.org/c/coreboot/+/34706/7/src/soc/intel/cannonlake/in...
PS7, Line 32:
Is there a reason why this was chosen to be fixed width before?
Probably just implementation date somewhere 2012 when uintptr_t was not so well known.
BTW CB:34747 removes the smram_ fields and same might be possible with ied_.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bc2c3c1dd579f7c6c3d3354c0691e4ba3c778e1
Gerrit-Change-Number: 34706
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Aug 2019 20:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment