Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, sridhar siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80362?usp=email )
Change subject: soc/intel/cmn/sa: Add APIs into System Agent (SA) common code ......................................................................
Patch Set 9:
(6 comments)
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/80362/comment/9c89ff94_0dc00230 : PS8, Line 330: uint32_t
const?
Acknowledged
https://review.coreboot.org/c/coreboot/+/80362/comment/3e036424_1568fa8d : PS8, Line 361: pciexbar_reg & PCIEXBAR_LENGTH_MASK
Shift the bits?
Acknowledged
https://review.coreboot.org/c/coreboot/+/80362/comment/127c3e03_f5cffcb7 : PS8, Line 373: uint32_t
const?
Acknowledged
https://review.coreboot.org/c/coreboot/+/80362/comment/4c8af32f_18d8306f : PS8, Line 402: uint64_t size;
is this variable necessary? Just return size straight away in the switch statement?
Acknowledged
https://review.coreboot.org/c/coreboot/+/80362/comment/c6dd47e2_83fa1188 : PS8, Line 403: uint32_t size_field
const?
Acknowledged
https://review.coreboot.org/c/coreboot/+/80362/comment/2f510801_edd88d93 : PS8, Line 417: default:
move above case 0?
Acknowledged