Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45287 )
Change subject: amdfwtool: Apply the change of config file to stoneyridge
......................................................................
Patch Set 27:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw...
File src/soc/amd/stoneyridge/fw_cz.cfg:
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw...
PS22, Line 3: #XHCI_FWM_FILE xhci.bin
It might be useful to call this TODO out in the commit message as remaining as a command line option […]
Done
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw...
File src/soc/amd/stoneyridge/fw_st.cfg:
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw...
PS22, Line 4: #XHCI_FWM_FILE xhci.bin
Same, it would be useful to understand why this is included but commented out in the cfg.
Done. Removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0536f854de533a7419c50da8a2b54d3635b55c61
Gerrit-Change-Number: 45287
Gerrit-PatchSet: 27
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Dave Frodin
dave.frodin@se-eng.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 01 Oct 2020 10:33:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-MessageType: comment