Attention is currently required from: Ravi kumar.
Sajida Bhanu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50586 )
Change subject: HACK sc7280: QSIP SPI NOR addressing mode HACK
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/c/coreboot/+/50586/comment/f65f7f2e_88aa2a60
PS4, Line 493: if (reg8 & 0x20){
space required before the open brace '{'
sure
https://review.coreboot.org/c/coreboot/+/50586/comment/f9fe8af4_9627c04c
PS4, Line 497: while (1);
trailing statements should be on next line
sure
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4
Gerrit-Change-Number: 50586
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Sajida Bhanu
sbhanu@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Comment-Date: Tue, 02 Mar 2021 06:59:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment