Attention is currently required from: Anand Vaikar, Felix Held, Martin L Roth.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80770?usp=email )
Change subject: mb/amd/birman_plus: Add glinda SOC option for Birman+ ......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/amd/birman_plus/Kconfig:
https://review.coreboot.org/c/coreboot/+/80770/comment/5791816f_a5fd12e2 : PS3, Line 82: # This is a Birmanplus_Phoenix-specific override of soc/amd/(phoenix | glinda)/Kconfig `Birmanplus_Phoenix` or just `birmanplus`?
File src/mainboard/amd/birman_plus/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/80770/comment/9dc22310_b9be0de5 : PS3, Line 7: bool "-> Birmanplus for Glinda SoC" Inconsistent capitalization - should this match the `BirmanPlus` for phoenix?
File src/mainboard/amd/birman_plus/port_descriptors_phoenix.c:
https://review.coreboot.org/c/coreboot/+/80770/comment/d2e23e3c_594fa5cf : PS3, Line 7: //#include <soc/soc_util.h> dead code