Attention is currently required from: Michael Niewöhner, Nicholas Sudsgaard.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80452?usp=email )
Change subject: include/device/azalia_device.h: Add enum for misc field
......................................................................
Patch Set 4:
(2 comments)
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80452/comment/63bcf2ae_95bed4f0 :
PS2, Line 117: NO_JACK_PRESENCE_DETECT
nit: Add a comma here
Done
https://review.coreboot.org/c/coreboot/+/80452/comment/ff2e441c_4ed35bd0 :
PS2, Line 118: }
Missing a semicolon here but otherwise looks good to me.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80452?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70cbfca8541828a1e0c7280887060c04e4c71721
Gerrit-Change-Number: 80452
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 13 Feb 2024 14:38:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-MessageType: comment