[coreboot-gerrit] [S] Change in coreboot[main]: soc/amd: Ensure bank 0 is selected before accessing VBNV in CMOS

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Yu-Ping Wu.

Karthik Ramasubramanian has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83495?usp=email )

Change subject: soc/amd: Ensure bank 0 is selected before accessing VBNV in CMOS
......................................................................

Patch Set 4:

(1 comment)

File src/soc/amd/common/vboot/vbnv_cmos.c:

https://review.coreboot.org/c/coreboot/+/83495/comment/12988499_309c3af9?usp... :
PS4, Line 16: cmos_write(RTC_FREQ_SELECT_AMD, RTC_FREQ_SELECT);
Is there any harm in calling cmos_init(0) just like how it is done in ramstage during every boot. cmos_init does this along with other things including detecting the power failure, restoring from the flash backup etc.

If there are no power failures like the one this CL is trying to address, cmos_init just selects the bank and moves on.