Attention is currently required from: Nico Huber, Reto Buerki.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80261?usp=email )
Change subject: mb/up/squared: Make mini PCIe port mode configurable ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80261/comment/5d1ed07c_9bef6a8f : PS2, Line 9: Add ENABLE_MSATA config knob and pad configuration to put Mini PCIe port : into mSATA mode.
Hmm, I was about to suggest to disable the PCIe root port based on the […]
I think we should figure out if PCIe still works, so that we don't create confusion. Unfortunately, I don't have a board to help testing. I will see if I can get one.
File src/mainboard/up/squared/Kconfig:
https://review.coreboot.org/c/coreboot/+/80261/comment/f648c079_91dd3b8d : PS2, Line 77: config ENABLE_MSATA : bool "Use mini-PCIe port for mSATA" : default n
I used `mb/compulab/intense_pc` as a template, which provides the same `ENABLE_MSATA` knob. […]
Let's wait with that until we figured out what's going on with that GPIO.