Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29948 )
Change subject: soc/qualcomm/qcs405: Support for new SoC ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/29948/2/src/soc/qualcomm/qcs405/timer.c File src/soc/qualcomm/qcs405/timer.c:
https://review.coreboot.org/#/c/29948/2/src/soc/qualcomm/qcs405/timer.c@18 PS2, Line 18:
As a general rule for this whole SoC, do not duplicate any code that is not substantially different […]
Hi Julius, Thanks for start reviewing these Mistral patches. On the src/soc/qualcomm/common code abstraction part, we are planning to do that as a separate parallel activity to this Mistral set of patches. The idea is as you mention above to keep code common for sdm845, qcs405 and also any future socs. So we will post Mistral patches with comments addressed apart from 'common code'. We will take care of posting the 'common code' refactor separately and rebase (unmerged) mistral patches on top it at that point of time. That said, we have already started looking in to the 'common code' and should start showing up in some time.