Attention is currently required from: Paul Menzel, Angel Pons, Julius Werner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62830 )
Change subject: commonlib: endian: Qualify variable as volatile
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Looking at the comments in `ebda.c`, using write_le16() is already
a hack to avoid compiler trouble or warnings. In theory we could
allow using these functions for fixed addresses (i.e. not only
pointers to objects in the program; what C expects). But I actually
like the warning as it kind of reminds us what this API should be
used for.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0
Gerrit-Change-Number: 62830
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 02 May 2022 11:02:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment