Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19651 )
Change subject: nb/intel/gm45: Fix some errors/warnings given by checkpatch ......................................................................
nb/intel/gm45: Fix some errors/warnings given by checkpatch
This results in raminit_receive_enable_calibration.c producing no errors or warnings with checkpatch.
The issues fixed are: ERROR: that open brace { should be on the previous line WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Tested by compiling after making the changes.
Change-Id: I8d2f4f1fe2f17aa44c0a7090c178eee418defe78 Signed-off-by: Tristan Corrick tristancorrick86@gmail.com Reviewed-on: https://review.coreboot.org/19651 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/northbridge/intel/gm45/raminit_receive_enable_calibration.c 1 file changed, 7 insertions(+), 4 deletions(-)
Approvals: Arthur Heymans: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c index 0d346bf..c5614e1 100644 --- a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c +++ b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c @@ -209,11 +209,14 @@ /* F */{ { 0, 0 }, { 3, 3 }, { 6, 6 }, { 5, 5 } }, };
- const int cardF[] = - { dimms[0].card_type == 0xf, dimms[0].card_type == 0xf }; - const unsigned t_bound = + const int cardF[] = { + dimms[0].card_type == 0xf, + dimms[0].card_type == 0xf, + }; + + const unsigned int t_bound = (timings->mem_clock == MEM_CLOCK_1067MT) ? 9 : 12; - const unsigned p_bound = + const unsigned int p_bound = (timings->mem_clock == MEM_CLOCK_1067MT) ? 8 : 1;
rec_timing_t rec_timings[2][4] = {