You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32057 )
Change subject: mediatek/mt8183: modify vsim2 calibration
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32057/3/src/soc/mediatek/mt8183/mt6358.c
File src/soc/mediatek/mt8183/mt6358.c:
https://review.coreboot.org/#/c/32057/3/src/soc/mediatek/mt8183/mt6358.c@782
PS3, Line 782: VSIM2_CALI_POS_60_MV
It's weird to me that you define a lot of enum for different values and perform arithmetic computation on them...
What about rename 'vsim2_cali' to 'vsim2_cali_10mv' (or any better name) and remove those enums?
And line 781-784 looks equivalent to 'vsim2_cali = MAX(0, vsim2_cali - 6);'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dffdde89cbde91286d92e6c2b445f0b3d0ad2fe
Gerrit-Change-Number: 32057
Gerrit-PatchSet: 3
Gerrit-Owner: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Mar 2019 10:09:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
