Attention is currently required from: Angel Pons, Felix Held, Paul Menzel.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83196?usp=email )
Change subject: util/superiotool: Add extra selectors support ......................................................................
Patch Set 5:
(1 comment)
File util/superiotool/superiotool.c:
https://review.coreboot.org/c/coreboot/+/83196/comment/69eddc3c_37b3d9a5?usp... : PS5, Line 87: static void set_extra_selector(uint16_t port, const struct extra_selector *esel) : { : if (esel->idx == 0) /* entry without extra selector */ : return; : : uint8_t reg_val = regval(port, esel->idx); : reg_val &= ~esel->mask; : reg_val |= esel->val; : regwrite(port, esel->idx, reg_val); : : reg_val = regval(port, esel->idx) & esel->mask; : : printf(" -- ESEL[%02xh] 0x%02x", esel->idx, reg_val); : if (esel->name != NULL) : printf(" (%s)", esel->name); : printf(" --"); : : if (verbose) : printf(" config: idx=%02xh, mask=%02xh, val=%02xh state --", esel->idx, esel->mask, : esel->val); : } :
What does this look like in the superiotool output? I don't see any newlines so it seems like it wou […]
If you mean the absence of a line break \n, then it is already taken into account in dump_regs().
``` superiotool r24.05-444-g3088e59717 Found Fintek F81962/F81964/F81966/F81967 (vid=0x3419, id=0x0215) at 0x2e (Global) -- ESEL[27h] 0x00 (Port Select Register) -- idx 02 07 20 21 23 24 25 26 27 28 29 2a 2b 2c 2d val 00 0b 15 02 19 34 5a 23 80 a0 f0 45 02 e3 2e def NA 00 15 02 19 34 00 23 02 a0 00 00 02 0c 28 (Global) -- ESEL[27h] 0x04 (Port Select Register) -- idx 27 28 2a 2b 2c val 84 00 00 00 00 def 02 00 00 00 00 (Global) -- ESEL[27h] 0x08 (Port Select Register) -- idx 27 28 2a 2b 2c val 88 03 60 03 01 def 02 03 60 00 00 (Global) -- ESEL[27h] 0x0c (Port Select Register) -- idx 27 28 2a 2b 2c val 8c 59 03 00 18 def 02 5b 03 00 18 (Global) -- ESEL[27h] 0x01 (Port Select Register) -- idx 27 29 2c 2b 2c val 81 03 00 00 00 def 02 03 e7 NA 00 LDN 0x03 (LPT) * * * ```
Alternative dump: ``` (Global) -- ESEL[27h] 0x00 (Port Select Register) -- idx def val 0x02: (NA) 0x00 0x07: 0x00 [0x0b] * * * ``` and with -V ``` (Global) -- ESEL[27h] 0x00 (Port Select Register) -- config: idx=27h, mask=0dh, val=00h state -- ```