Attention is currently required from: Karthik Ramasubramanian, hualin wei.
Subrata Banik has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/83906?usp=email )
Change subject: mb/google/dedede/var/awasuki: Adjust I2C frequency to less than 400 KHz
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83906/comment/54c75609_638621b7?usp... :
PS3, Line 38: I2C_SPEED_FAST - 30000
should follow the defined template as per I2C spec. If the controller doesn't support fast speed, please use the standard aka 100KHz
```
enum i2c_speed {
I2C_SPEED_STANDARD = 100000,
I2C_SPEED_FAST = 400000,
I2C_SPEED_FAST_PLUS = 1000000,
I2C_SPEED_HIGH = 3400000,
I2C_SPEED_FAST_ULTRA = 5000000,
};
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83906?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb75db1dc95ffd5ca806a194ae678c700fa0741c
Gerrit-Change-Number: 83906
Gerrit-PatchSet: 3
Gerrit-Owner: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 15 Aug 2024 06:28:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No